Skip to content

Fix incorrect exception catching of json responses #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james-panayis merged 1 commit into from
Jun 29, 2026
+2 −2
Merged

Fix incorrect exception catching of json responses #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions simvue/api/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def get_json_from_response(
json_response = response.json()
json_response = json_response or ({} if expected_type is dict else [])
decode_error = ""
except json_module.JSONDecodeError as e:
except requests.exceptions.JSONDecodeError as e:
json_response = {} if allow_parse_failure else None
decode_error = f"{e}"

Expand Down Expand Up @@ -419,7 +419,7 @@ def get_paginated(
_response.json().get("count", 0) < _offset
):
break
except json_module.JSONDecodeError:
except requests.exceptions.JSONDecodeError:
raise RuntimeError(
f"[{_response.status_code}] Failed to retrieve content from server: "
+ _response.text,
Expand Down
Loading