Fix incorrect exception catching of json responses#988
Merged
Conversation
This caused issues when simplejson happened to be present, as this makes requests change its exception inheritance structure
wk9874
approved these changes
Jun 29, 2026
wk9874
left a comment
wk9874
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, so long as CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python Version(s) Tested: 3.12.11
Operating System(s): Ubuntu
📝 Summary
This caused issues when simplejson happened to be present, as this makes requests change its exception inheritance structure
✔️ Checklist