Skip to content

Don't silently skip null assignment to OpenApiDocument.Tags #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 2 commits into from
Jun 29, 2026
+12 −0
Merged

Don't silently skip null assignment to OpenApiDocument.Tags #2916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98fa6f5
Don't silently skip null assignment to OpenApiDocument.Tags
Youssef1313 Jun 29, 2026
b8dbf98
Update OpenApiDocumentTests.cs
Youssef1313 Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Microsoft.OpenApi/Models/OpenApiDocument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public ISet<OpenApiTag>? Tags
{
if (value is null)
{
_tags = null;
return;
}
_tags = value switch
Expand Down
11 changes: 11 additions & 0 deletions test/Microsoft.OpenApi.Tests/Models/OpenApiDocumentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2145,6 +2145,17 @@ public void TagsSupportsCustomComparer()
Assert.Equal(2, document.Tags.Count);
}

[Fact]
public void TagsCanBeReInitializedToNull()
{
var document = new OpenApiDocument();
Assert.Null(document.Tags);
document.Tags = new HashSet<OpenApiTag>();
Assert.NotNull(document.Tags);
document.Tags = null;
Assert.Null(document.Tags);
}

private sealed class CaseInsensitiveOpenApiTagEqualityComparer : IEqualityComparer<OpenApiTag>
{
public bool Equals(OpenApiTag x, OpenApiTag y)
Expand Down