Skip to content

Don't silently skip null assignment to OpenApiDocument.Tags#2916

Merged
baywet merged 2 commits into
microsoft:mainfrom
Youssef1313:patch-1
Jun 29, 2026
Merged

Don't silently skip null assignment to OpenApiDocument.Tags#2916
baywet merged 2 commits into
microsoft:mainfrom
Youssef1313:patch-1

Conversation

@Youssef1313

@Youssef1313 Youssef1313 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Don't silently skip null assignment to OpenApiDocument.Tags

Description

Currently, assigning null to the Tags property will silently be skipped. This regression from 93c468e

The property is updated so that it doesn't silently return without doing the assignment.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Related Issue(s)

Changes Made

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • All existing tests pass

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Versions applicability

  • My change applies to the version 1.X of the library, if so PR link:
  • My change applies to the version 2.X of the library, if so PR link:
  • My change applies to the version 3.X of the library, if so PR link:
  • I have evaluated the applicability of my change against the other versions above.

See the contributing guidelines for more information about how patches are applied across multiple versions.

Additional Notes

@Youssef1313 Youssef1313 requested a review from a team as a code owner June 29, 2026 15:19

@baywet baywet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@baywet baywet merged commit 3764142 into microsoft:main Jun 29, 2026
9 checks passed
@Youssef1313 Youssef1313 deleted the patch-1 branch June 29, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants