Skip to content

P1: fix Zig FFI to build and match the Idris2 ABI #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Jun 26, 2026
Merged

P1: fix Zig FFI to build and match the Idris2 ABI #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/interface/ffi/src/main.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ export fn oblibeniser_undo_pop(handle: ?*Handle) u64 {
return 0;
};

const op_id = h.undo_stack.popOrNull() orelse {
const op_id = h.undo_stack.pop() orelse {
setError("Undo stack empty");
return 0;
};
Expand Down Expand Up @@ -601,10 +601,24 @@ test "compute and verify inverse" {
const handle = oblibeniser_init() orelse return error.InitFailed;
defer oblibeniser_free(handle);

const op_id = oblibeniser_record_forward(handle, 0, 0);
_ = oblibeniser_finalise_forward(handle, op_id, 0);
// Record with a real pre-state snapshot, then finalise with a real
// post-state snapshot: compute_inverse requires both to be present.
var pre = std.mem.zeroes(StateSnapshot);
pre.state_hash = 0x1111;
var post = std.mem.zeroes(StateSnapshot);
post.state_hash = 0x2222;

const op_id = oblibeniser_record_forward(handle, 0, @intFromPtr(&pre));
try std.testing.expect(op_id != 0);

const finalise = oblibeniser_finalise_forward(handle, op_id, @intFromPtr(&post));
try std.testing.expectEqual(Result.ok, finalise);

const compute = oblibeniser_compute_inverse(handle, op_id);
try std.testing.expectEqual(Result.ok, compute);

const verify = oblibeniser_verify_inverse(handle, op_id);
try std.testing.expectEqual(Result.ok, verify);
}

test "undo stack push and pop" {
Expand Down
Loading