P1: fix Zig FFI to build and match the Idris2 ABI#29
Merged
Conversation
The Zig FFI in src/interface/ffi/src/main.zig failed `zig test src/main.zig -lc` under Zig 0.14.0 and one test asserted behaviour the ABI contract does not provide. Errors found: 1. Compile error: `array_list.ArrayListAligned` no longer exposes `popOrNull`. `oblibeniser_undo_pop` called `h.undo_stack.popOrNull()`, which does not exist in Zig 0.14.0. 2. Test failure: the "compute and verify inverse" test finalised the operation with a null (0) post-snapshot pointer, so `post_snapshot` stayed null and `oblibeniser_compute_inverse` correctly returned `not_reversible` (per its contract: an inverse needs both pre- and post-state snapshots). The test asserted `ok`, so it failed. Fixes: 1. Replaced `popOrNull()` with `pop()`, which in Zig 0.14.0 already returns an optional (`?T`); the `orelse` empty-stack handling is unchanged. 2. Updated the test to record with a real pre-state snapshot and finalise with a real post-state snapshot, then assert `ok` for compute_inverse and additionally verify_inverse. This exercises the documented contract instead of weakening the FFI logic. The Idris2 ABI (src/interface/abi/Oblibeniser/ABI/Foreign.idr + Types.idr) remains the source of truth: every `C:<name>` symbol still has a matching `export fn`, and the Result enum integer values (Ok=0 .. InverseProofFailed=7) are unchanged and match resultToInt. Verification: - `zig test src/main.zig -lc` -> all 7 tests pass, zero errors/warnings. - `idris2 --build oblibeniser-abi.ipkg` -> exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xMKB3T4Vo5FYC7Czx3JSH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Zig FFI in
src/interface/ffi/src/main.zigfailedzig test src/main.zig -lcunder Zig 0.14.0, and one test asserted behaviour the ABI contract does not provide. This PR fixes both, keeping the Idris2 ABI (src/interface/abi/Oblibeniser/ABI/Foreign.idr+Types.idr) as the source of truth.Errors found
Compile error —
array_list.ArrayListAlignedno longer exposespopOrNullin Zig 0.14.0.oblibeniser_undo_popcalledh.undo_stack.popOrNull():Test failure — the
"compute and verify inverse"test finalised the operation with a null (0) post-snapshot pointer, sopost_snapshotstayed null andoblibeniser_compute_inversecorrectly returnednot_reversible(its contract requires both pre- and post-state snapshots). The test assertedok:Fixes
popOrNull()withpop(), which in Zig 0.14.0 already returns an optional (?T); theorelseempty-stack handling is unchanged.okforcompute_inverseand additionallyverify_inverse. This exercises the documented contract instead of weakening the FFI logic.No exported C symbol names or
Resultenum integer values were changed.ABI conformance
C:<name>inForeign.idrhas a matchingexport fn <name>(20/20 symbols, verified by diff — no missing/extra symbols).Resultenum values matchresultToInt:Ok=0, Error=1, InvalidParam=2, OutOfMemory=3, NullPointer=4, NotReversible=5, AuditViolation=6, InverseProofFailed=7.Verification
cd src/interface/ffi && zig test src/main.zig -lc→ all 7 tests pass, zero errors/warnings.cd src/interface/abi && idris2 --build oblibeniser-abi.ipkg→ exit 0 (build dir removed afterwards).Only
src/interface/ffi/src/main.zigis touched.🤖 Generated with Claude Code
https://claude.ai/code/session_019xMKB3T4Vo5FYC7Czx3JSH
Generated by Claude Code