chore(meetings): update meetings e2e test workflow#705
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00419972b9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| path: | | ||
| **/playwright-report/** | ||
| **/test-results/** |
There was a problem hiding this comment.
When the meetings E2E job fails, this upload step won't collect the generated report: yarn workspace @webex/widgets run test:e2e runs WebdriverIO, and packages/@webex/widgets/wdio.conf.js writes JUnit output to ./test_results/e2e (underscore), not Playwright's playwright-report or hyphenated test-results. In that failure scenario the artifact action will warn/no-op, leaving the new diagnostics unavailable.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this is for the upcoming playwright e2e tests
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79ae3092cb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| - name: Test E2E | ||
| run: yarn workspace @webex/widgets run test:e2e | ||
| run: yarn run test:e2e:meetings |
There was a problem hiding this comment.
When a PR has the run_e2e label, this step now invokes a root script that does not exist; I checked all package.json files and only test:e2e is defined (plus the legacy packages/@webex/widgets test:e2e), and Yarn 4 run only executes a matching package script/binary or unique workspace script. The same problem exists for yarn run test:e2e:cc later in this workflow, so the labeled E2E workflow either fails immediately or, for the meetings job with continue-on-error, records no test coverage.
Useful? React with 👍 / 👎.
1 participant
COMPLETES #NA
This pull request addresses
update e2e test workflow for meetings e2e tests
by making the following changes
added a upload artifact step & added a browser installation steps
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.