Remove duckdbfs#8468
Conversation
fa938c8 to
e41bcc7
Compare
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
162.1 µs | 198.6 µs | -18.39% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
178.2 µs | 214.7 µs | -17.01% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
274 µs | 308.4 µs | -11.15% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
214.7 µs | 177.8 µs | +20.8% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
215.3 ns | 186.1 ns | +15.67% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
275.6 ns | 246.4 ns | +11.84% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing myrrc/remove-duckdbfs (43a74b1) with develop (202953d)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
e41bcc7 to
43a74b1
Compare
Duckdb fs implementation for Vortex suffers from glob expansion issues and performance issue, so it's turned off by default.
We don't want to call into duckdb's blocking IO inside out event loop but instead allow duckdb to do IO for us.
As first step, remove duckdbfs implementation