Skip to content

Remove duckdbfs#8468

Draft
myrrc wants to merge 1 commit into
developfrom
myrrc/remove-duckdbfs
Draft

Remove duckdbfs#8468
myrrc wants to merge 1 commit into
developfrom
myrrc/remove-duckdbfs

Conversation

@myrrc

@myrrc myrrc commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Duckdb fs implementation for Vortex suffers from glob expansion issues and performance issue, so it's turned off by default.
We don't want to call into duckdb's blocking IO inside out event loop but instead allow duckdb to do IO for us.
As first step, remove duckdbfs implementation

@myrrc myrrc added changelog/feature A new feature ext/duckdb Relates to the DuckDB integration labels Jun 17, 2026
@myrrc myrrc force-pushed the myrrc/remove-duckdbfs branch from fa938c8 to e41bcc7 Compare June 17, 2026 14:45
@myrrc myrrc marked this pull request as ready for review June 17, 2026 14:45
@myrrc myrrc requested review from a team and gatesn June 17, 2026 14:45
@myrrc myrrc marked this pull request as draft June 17, 2026 15:09
@myrrc myrrc linked an issue Jun 17, 2026 that may be closed by this pull request
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 3 regressed benchmarks
✅ 1575 untouched benchmarks
⏩ 3 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 162.1 µs 198.6 µs -18.39%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 178.2 µs 214.7 µs -17.01%
Simulation chunked_varbinview_canonical_into[(100, 100)] 274 µs 308.4 µs -11.15%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 214.7 µs 177.8 µs +20.8%
Simulation bitwise_not_vortex_buffer_mut[128] 215.3 ns 186.1 ns +15.67%
Simulation bitwise_not_vortex_buffer_mut[1024] 275.6 ns 246.4 ns +11.84%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/remove-duckdbfs (43a74b1) with develop (202953d)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc myrrc added changelog/break A breaking API change and removed changelog/feature A new feature labels Jun 18, 2026
@myrrc myrrc requested a review from 0ax1 June 18, 2026 11:00
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/remove-duckdbfs branch from e41bcc7 to 43a74b1 Compare June 18, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance regressions in duckdbfs

1 participant