style: use full paths for internal headers in capi/...#313
style: use full paths for internal headers in capi/...#313VDanielEdwards wants to merge 1 commit into
capi/...#313Conversation
|
Is there any particular reason you chose the google style guide? I have found that using the llvm style guide leads to headers being more self-contained. |
VDanielEdwards
force-pushed
the
dev/refactor/use-full-include-paths-capi
branch
from
d46ede3 to
dda8abe
Compare
No particular reason, it was just the first that came to mind. But I do like the ordering from local -> global as in the LLVM styleguide more than what the Google styleguide suggests. @MariusBgm would you object to switching the include-order to the LLVM styleguide? |
VDanielEdwards
requested review from
snps-behrens
and removed request for
snps-behrens
snps-behrens
left a comment
snps-behrens
left a comment
There was a problem hiding this comment.
Looks pretty good. I did notice you removed pretty much all system includes from these files, even where there is extensive use of the standard library. Is that intentional?
| #include "silkit/participant/IParticipant.hpp" | ||
| #include "silkit/services/orchestration/all.hpp" | ||
|
|
||
| #include <map> |
There was a problem hiding this comment.
Why remove mutex here? It's still used in this file.
I got a bit overzealous there I think. Re-added in the latest fixup commit. Good catch! |
|
The build error is resolved on main. If you don't mind, I would rebase this branch @snps-behrens ? |
|
Go ahead and rebase. Thanks for warning me. 👍 |
Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
VDanielEdwards
force-pushed
the
dev/refactor/use-full-include-paths-capi
branch
from
0fb7d2f to
1d1c083
Compare
3 participants
Subject
Use full paths for internal headers in all sources and headers in
SilKit/source/capi/. Rearranges the includes to follow the guidelines in the LLVM Styleguide for C++Google Styleguide for C++. Removes unneccessary includes.Developer checklist (address before review)