fix: drop git-source deps from Gemfile#70
Open
ronaldtse wants to merge 1 commit into
Open
Conversation
Release gems must not depend on git sources. The Gemfile overrides for lutaml-model and plurimath point at GitHub main, but both gems are already published on RubyGems: - lutaml-model 0.8.16 (gemspec already declares ~> 0.8.0) - plurimath 0.11.3 (not a runtime dep; needed only by specs that exercise Unitsml::Formula#to_plurimath) Changes: - Drop the `gem "lutaml-model", github: ...` line; fall through to the gemspec constraint (~> 0.8.0). - Replace `gem "plurimath", github: ...` with `gem "plurimath", "~> 0.11.3"` so the Gemfile pulls the published gem. Verified locally: bundle install resolves both from RubyGems, and bundle exec rake spec passes (398 examples, 0 failures).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gem "lutaml-model", github: ...override; fall through to gemspeclutaml-model ~> 0.8.0gem "plurimath", github: ...withgem "plurimath", "~> 0.11.3"bundle exec rake spec→ 398 examples, 0 failuresWhy
A release gem must not carry
gem "X", github: "..."in its Gemfile: therelease CI workflow (
metanorma/ci/.github/workflows/rubygems-release.yml)deletes
Gemfile.lockand re-resolves withbundle install, whichcannot reliably materialize git-source deps.
Both
lutaml-model0.8.16 andplurimath0.11.3 are published onRubyGems, so the overrides are unnecessary.
plurimathis not in the gemspec (it is an optional conversiondependency — users add it to their own Gemfile if they want math
output). It must remain in this gem's Gemfile only because the spec
suite exercises
Unitsml::Formula#to_plurimath.Test plan
bundle installresolves both from RubyGemsbundle exec rake specpasses (398/398)