fix: drop git-source lutaml-model from Gemfile#29
Open
ronaldtse wants to merge 1 commit into
Open
Conversation
Release gems must not depend on git sources. The Gemfile override points at lutaml-model main on GitHub, but lutaml-model 0.8.16 is already published on RubyGems and the gemspec already declares lutaml-model ~> 0.8.0. Removing the override lets Bundler resolve to the published gem. Verified locally: bundle install resolves to lutaml-model 0.8.16 from RubyGems, and bundle exec rake spec passes (811 examples, 0 failures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gem "lutaml-model", github: ..., branch: "..."override fromGemfilebundle installresolvelutaml-model ~> 0.8.0(already inunitsdb.gemspec) from RubyGemsbundle exec rake spec→ 811 examples, 0 failures; resolves tolutaml-model 0.8.16Why
A release gem must not carry
gem "X", github: "..."in its Gemfile: therelease CI workflow (
metanorma/ci/.github/workflows/rubygems-release.yml)deletes
Gemfile.lockand re-resolves dependencies withbundle install,which cannot reliably materialize git-source deps without bundler-specific
workarounds.
lutaml-model0.8.16 is already published on RubyGems, so the override isunnecessary and the existing gemspec constraint is sufficient.
Test plan
bundle installresolves cleanly to RubyGems-only depsbundle exec rake specpasses (811/811)