docs(trc-4626): restore Security Considerations notes agreed in #840 (share-inflation mitigation + decimal basis)#898
Open
BlackChar92 wants to merge 1 commit into
Conversation
…rotocol#840 Adds the share-inflation/donation mitigation and decimal-basis notes that the tronprotocol#840 Last Call summary said would be folded in but never landed in tip-4626.md. Non-normative: Security Considerations text only; no interface/event/behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #897 / #840.
The April-17 Last Call summary in #840 stated that two non-normative implementation notes would be folded into Security Considerations before Last Call — the share-inflation / donation mitigation and a decimal-basis note — but neither made it into the published
tip-4626.md. This PR adds them.Non-normative clarification only. Security Considerations text; no change to the interface, events, rounding requirements, or any required behavior (TRC-4626 is Final).
decimals()from both the vault and the underlying rather than hardcoding.Closes #897.