Skip to content

Improve mobile integrations layout#1097

Open
ishaanxgupta wants to merge 1 commit into
mainfrom
codex/mobile-integrations-activity-list
Open

Improve mobile integrations layout#1097
ishaanxgupta wants to merge 1 commit into
mainfrom
codex/mobile-integrations-activity-list

Conversation

@ishaanxgupta

@ishaanxgupta ishaanxgupta commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a mobile-only Activity panel with Active and Recent tabs near the top of the integrations page.
  • Switch mobile integration cards from horizontal carousel cards to compact vertical list rows.
  • Keep the existing desktop right-column layout unchanged.
image

@ishaanxgupta ishaanxgupta changed the title [codex] Improve mobile integrations layout Improve mobile integrations layout Jun 11, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 236bcbe Jun 11 2026, 03:17 PM

@ishaanxgupta ishaanxgupta marked this pull request as ready for review June 11, 2026 14:13
@graphite-app graphite-app Bot requested a review from Dhravya June 11, 2026 14:13
@claude

claude Bot commented Jun 11, 2026

Copy link
Copy Markdown

Claude finished @ved015's task in 46s —— View job


Reviewing PR #1097

  • Fetch and analyze PR diff
  • Review for bugs, security issues, and logic errors
  • Check existing review comments
  • Provide review summary

Overview: Adds a mobile-optimized Activity panel with Active/Recent tabs and switches mobile integration cards from horizontal carousel to vertical list layout.

Issues found: None — this looks good to ship.

The implementation is clean and correct:

  • MobileActivityPanel follows existing component patterns and properly reuses PluginRailRow, ConnectorRailRow, RecentDocRow, RailEmpty, and RailSkeleton
  • The useEffect that auto-switches to the available tab when content changes has correct dependencies and logic
  • The activeTab derivation handles all edge cases properly (loading states, empty states, user selection)
  • The extracted openRecentDoc callback correctly handles both the onOpenDocument prop and setDocId fallback
  • Responsive breakpoints (lg:hidden / hidden lg:block) preserve desktop layout while enabling mobile changes
  • List keys use appropriate identifiers (entry.id, doc.id ?? doc.customId)
  • No security concerns, data handling issues, or breaking changes

Score: 10/10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a mobile-optimized Activity panel with Active/Recent tabs and switches mobile integration cards from horizontal carousel to vertical list layout.

Issues found: None — this looks good to ship.

The implementation is clean:

  • MobileActivityPanel follows existing patterns (reuses PluginRailRow, ConnectorRailRow, RecentDocRow, RailEmpty, RailSkeleton)
  • The useEffect that auto-switches to "recent" tab when "active" is empty is a nice UX touch
  • Proper handling of loading and empty states
  • The openRecentDoc callback extraction is a good refactor that removes duplication
  • Responsive breakpoints are correctly applied (lg:hidden / hidden lg:block) to preserve desktop layout
  • List keys are properly set using existing patterns (entry.id, doc.id ?? doc.customId)

Score: 10/10

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 236bcbe Commit Preview URL

Branch Preview URL
Jun 11 2026, 03:19 PM

@ishaanxgupta ishaanxgupta force-pushed the codex/mobile-integrations-activity-list branch 3 times, most recently from 1449d39 to f87b94c Compare June 11, 2026 15:07
@ishaanxgupta ishaanxgupta force-pushed the codex/mobile-integrations-activity-list branch from f87b94c to 236bcbe Compare June 11, 2026 15:10
@ved015 ved015 closed this Jun 11, 2026
@ved015 ved015 reopened this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants