Skip to content

PLUG-4656: MicrosoftDefender - Fix Device Import not working#65

Merged
jame2O merged 2 commits into
mainfrom
work/jd/PLUG-4656
Jun 16, 2026
Merged

PLUG-4656: MicrosoftDefender - Fix Device Import not working#65
jame2O merged 2 commits into
mainfrom
work/jd/PLUG-4656

Conversation

@jame2O

@jame2O jame2O commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

  • PR to fix issues experienced by Evida & other customers with Device imports.
  • Main change is the ordering of operations to improve performance (likely minimal but there) and a change to the way we check for invalid rows. Evida are having issues with this, so the potential fix is to move to an isnotempty check over != to exclude null DeviceNames
  • Removed redundant columns from Device objects as to speed up the query.

🧩 Plugin details

  • Plugin name:
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe):

⚠️ Breaking changes

Does this PR introduce any breaking changes?

  • No
  • Yes (please describe):

If yes, describe:

  • What breaks
  • Who is impacted
  • Any migration steps

📚 Documentation

  • Documentation updated
  • No documentation changes needed

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

@jame2O jame2O requested review from a team, TimWheeler-SQUP and vinbab June 16, 2026 11:29
@jame2O jame2O added bug Something isn't working plugin: Microsoft Defender labels Jun 16, 2026
@github-actions

Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/MicrosoftDefender/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

microsoft-defender
{
  "valid": true,
  "pluginName": "microsoft-defender",
  "pluginType": "hybrid",
  "summary": {
    "Data Streams": 12,
    "Import Definitions": 1,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": true,
    "Config Validation": true,
    "Custom Types": true
  }
}

@jame2O jame2O marked this pull request as draft June 16, 2026 11:32
@WaynePlummer WaynePlummer changed the title PLUG-4656: Fix Device Import not working PLUG-4656: MicrosoftDefender - Fix Device Import not working Jun 16, 2026
@jame2O jame2O marked this pull request as ready for review June 16, 2026 12:03
@TimWheeler-SQUP

Copy link
Copy Markdown
Contributor

@claude review

@TimWheeler-SQUP TimWheeler-SQUP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved.

@jame2O jame2O merged commit 6c9ac76 into main Jun 16, 2026
1 check passed
@jame2O jame2O deleted the work/jd/PLUG-4656 branch June 16, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working plugin: Microsoft Defender

Development

Successfully merging this pull request may close these issues.

3 participants