Skip to content

fix!: support source archive upgrades#762

Merged
damacus merged 1 commit into
mainfrom
fix/java-source-archive-upgrades
Jun 22, 2026
Merged

fix!: support source archive upgrades#762
damacus merged 1 commit into
mainfrom
fix/java-source-archive-upgrades

Conversation

@damacus

@damacus damacus commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Add version-aware source archive installs with source_install_dir support
  • Pass java_home_owner through openjdk_install for source installs
  • Make Debian alternatives detection idempotent by checking /var/lib/dpkg/alternatives
  • Raise the minimum Chef Infra version to 17.5 for archive_file strip_components support

Closes #745
Closes #708
Closes #649

Verification

  • chef exec ruby -c resources/openjdk_install.rb
  • chef exec ruby -c resources/openjdk_source_install.rb
  • chef exec ruby -c resources/alternatives.rb
  • cookstyle
  • chef exec rspec --format documentation
  • markdownlint-cli2 documentation/resources/openjdk_install.md documentation/resources/openjdk_source_install.md
  • KITCHEN_LOCAL_YAML=kitchen.dokken.yml kitchen converge openjdk-17-ubuntu-2404
  • KITCHEN_LOCAL_YAML=kitchen.dokken.yml kitchen converge openjdk-17-ubuntu-2404 (0/9 resources updated)
  • KITCHEN_LOCAL_YAML=kitchen.dokken.yml kitchen verify openjdk-17-ubuntu-2404

Add version-aware source archive installs with source_install_dir support, pass java_home_owner through openjdk_install, and make Debian alternatives detection idempotent.

Closes #745
Closes #708
Closes #649
@damacus damacus requested a review from a team as a code owner June 22, 2026 10:26
@github-actions

Copy link
Copy Markdown

Slowest examples

Top 10 slowest examples (0.47 seconds, 46.47% of total time)
Example Description Time in seconds
spec/resources/openjdk_source_install_spec.rb:81 openjdk_source_install custom source URL with source_install_dir uses source_install_dir under the versioned parent directory 0.0898
spec/resources/openjdk_pkg_install_spec.rb:16 openjdk_pkg_install does not write node java_home state 0.0852
spec/resources/alternatives_spec.rb:8 java_alternatives converges with an empty command list without shelling out 0.05939
spec/resources/certificate_spec.rb:16 java_certificate steps into certificate install without invoking host keytool 0.03684
spec/resources/temurin_package_install_spec.rb:12 temurin_package_install installs the Adoptium apt keyring 0.03559
spec/resources/jce_spec.rb:14 java_jce install extracts the archive without a shell execute resource 0.0353
spec/resources/temurin_package_install_spec.rb:32 temurin_package_install on AlmaLinux uses the RHEL-compatible Adoptium RPM repository 0.03527
spec/resources/openjdk_source_install_spec.rb:25 openjdk_source_install install extracts the archive into the final java_home 0.03422
spec/resources/openjdk_pkg_install_spec.rb:12 openjdk_pkg_install installs the requested OpenJDK packages 0.03414
spec/resources/temurin_package_install_spec.rb:19 temurin_package_install configures the apt repository with signed_by instead of trusted mode 0.03379

@damacus damacus enabled auto-merge (squash) June 22, 2026 10:29
@damacus damacus disabled auto-merge June 22, 2026 13:25
@damacus damacus merged commit 97433ea into main Jun 22, 2026
137 checks passed
@damacus damacus deleted the fix/java-source-archive-upgrades branch June 22, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing property java_home_owner Cant seem to install anything but the default OpenJDK 17 version Cannot upgrade java version

1 participant