chore/executors: docs fixup and smoke test#1393
Open
DaedalusG wants to merge 3 commits into
Open
Conversation
DaedalusG
force-pushed
the
wg/plat/improve-executors-docs-and-bugs
branch
from
d94c3fa to
2ed538c
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-019ede70-71bd-726d-91b8-894438340faf Co-authored-by: Amp <amp@ampcode.com>
DaedalusG
force-pushed
the
wg/plat/improve-executors-docs-and-bugs
branch
from
2ed538c to
90d61b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes PLAT-745
This PR fixes up some docs problems and adds a smoke test for quickly testing the chart can start and connect to a running docker instance. The smoke test is prepared to plug into CI but not yet plugged in.
Checklist
Test plan
I ran the smoke test operations manually and then ran the smoke test script using a docker compose instance of sourcegraph running in 7.4.0