Phase-1 follow-up: activate the Avalonia browse table#967
Draft
johnml1135 wants to merge 1 commit into
Draft
Conversation
Stacked on the rule-formula follow-up. The browse table view code (LexicalBrowseView, LexicalBrowseHostControl, BulkEditBarView, ClerkBrowse*) and its RecordBrowseView product wiring already shipped dormant in the base PR (they are fused to base wiring, so they could not be carved out). This PR is the activation flip: - move the 8 browse tool names (lexiconEdit, lexiconBrowse, notebookEdit, notebookBrowse, Analyses, toolBulkEditWordforms, featureTypesAdvancedEdit, reversalToolReversalIndexPOS) from Phase1FollowUpBrowseTools into SupportedAvaloniaBrowseToolNames; Phase1FollowUpBrowseTools is now empty - flip the 4 base inert-browse resolver tests back to asserting Avalonia under New (LexiconBrowse, LexiconEdit, RegisteredNonLexiconTool x6, ExplicitOverride), restoring the pre-split _YieldsAvalonia expectations Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
commit 47dbc776c5: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase-1 follow-up: activate the Avalonia browse table
Stacked on the rule-formula follow-up. Pure activation flip — the table view code (
LexicalBrowseView,LexicalBrowseHostControl,BulkEditBarView,ClerkBrowse*) and itsRecordBrowseViewwiring already shipped (dormant) in the base PR, because they are fused to base wiring and could not be carved into a separate code PR.lexiconEdit,lexiconBrowse,notebookEdit,notebookBrowse,Analyses,toolBulkEditWordforms,featureTypesAdvancedEdit,reversalToolReversalIndexPOS) fromPhase1FollowUpBrowseToolsintoSupportedAvaloniaBrowseToolNames.2-file change. Verification: build green; resolver/browse suites 142/142.
This change is