Move ErrorUtils from cxxreact to jserrorhandler (#57236)#57236
Open
javache wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108786498. |
Summary:
Move `handleJSError` from `cxxreact/ErrorUtils.h` (header-inline) to `jserrorhandler/ErrorUtils.{h,cpp}` (declared + linked). Inverts the cyclic dep so `jserrorhandler` becomes a standalone leaf and `cxxreact:bridge` can be narrowed out of more consumers in follow-ups.
The old `<cxxreact/ErrorUtils.h>` include path continues to work via a deprecated `#warning` forwarder header that includes the new location. `cxxreact:bridge` now depends on `jserrorhandler:jserrorhandler` so existing consumers of the deprecated path still link cleanly. `jserrorhandler/BUCK` drops its `cxxreact:bridge` dep (and the matching `React-cxxreact` podspec entry).
Changelog:
[Internal]
Reviewed By: christophpurrer
Differential Revision: D108786498
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D108786498
branch
from
8967bc5 to
db6f914
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move
handleJSErrorfromcxxreact/ErrorUtils.h(header-inline) tojserrorhandler/ErrorUtils.{h,cpp}(declared + linked). Inverts the cyclic dep sojserrorhandlerbecomes a standalone leaf andcxxreact:bridgecan be narrowed out of more consumers in follow-ups.The old
<cxxreact/ErrorUtils.h>include path continues to work via a deprecated#warningforwarder header that includes the new location.cxxreact:bridgenow depends onjserrorhandler:jserrorhandlerso existing consumers of the deprecated path still link cleanly.jserrorhandler/BUCKdrops itscxxreact:bridgedep (and the matchingReact-cxxreactpodspec entry).Changelog:
[Internal]
Reviewed By: christophpurrer
Differential Revision: D108786498