fix: make non-base64 media paths relative to report location#1040
Open
decembercomposer697-hue wants to merge 1 commit into
Open
fix: make non-base64 media paths relative to report location#1040decembercomposer697-hue wants to merge 1 commit into
decembercomposer697-hue wants to merge 1 commit into
Conversation
When extra media content is a file path (not base64), it was previously used as-is in the HTML, creating absolute paths that break when the report is moved. Now resolves relative to the report's parent directory.
Author
|
Hi! This PR fixes the issue where non-base64 media paths were absolute instead of relative to the report location. All unit tests pass. Would appreciate a review! |
RonnyPfannschmidt
requested changes
Jun 19, 2026
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
Member
There was a problem hiding this comment.
This needs some tests added that would fail without the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309: when extra media content is a file path (not base64),
it was used as-is in HTML, creating absolute paths. Now resolves
relative to the report's parent directory.
✅ Unit tests pass (7/7)