Skip to content

C_GetInterface for PKCS#11 3.0, 3.2 APIs#240

Open
MatthiasValvekens wants to merge 1 commit into
pyauth:masterfrom
MatthiasValvekens:feature/pkcs11-3x-interfaces
Open

C_GetInterface for PKCS#11 3.0, 3.2 APIs#240
MatthiasValvekens wants to merge 1 commit into
pyauth:masterfrom
MatthiasValvekens:feature/pkcs11-3x-interfaces

Conversation

@MatthiasValvekens

Copy link
Copy Markdown
Collaborator

This commit adds the plumbing needed to obtain and propagate the v3.0 and v3.2 function list at runtime.

This is necessary to support ML-KEM and other new features that depend on new functions.

I don't intend to merge this until the ML-KEM branch is ready (waiting for softhsm/SoftHSMv2#885 to get resolved for CI reasons), but I figured it wouldn't hurt to already put this up for review in the meantime.

This commit adds the plumbing needed to obtain and propagate the
v3.0 and v3.2 function list at runtime.

This is necessary to support ML-KEM and other new features.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.33%. Comparing base (1ff2114) to head (aca2117).
⚠️ Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
pkcs11/_pkcs11.pyx 77.27% 5 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   90.17%   91.33%   +1.16%     
==========================================
  Files          15       15              
  Lines        2625     2711      +86     
  Branches       29       27       -2     
==========================================
+ Hits         2367     2476     +109     
+ Misses        255      233      -22     
+ Partials        3        2       -1     
Flag Coverage Δ
unittests 91.33% <77.27%> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants