[codex] Allow removing stale remote backends while reconnecting#3247
[codex] Allow removing stale remote backends while reconnecting#3247StiensWout wants to merge 1 commit into
Conversation
Co-authored-by: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Simple UI change allowing the Disconnect button to be clickable during connection attempts, not just after connected. The change is self-contained to button state logic in a single settings component with no backend impact. You can customize Macroscope's approvability policy. Learn more. |
Summary
Root cause
The saved backend row disabled its only action while the connection phase was
connectingorreconnecting, so a stale backend could keep retrying without exposing the existing remove action.Impact
Users can remove stale remote or SSH backends even while the client is retrying the connection. Connected and disconnected backend behavior is otherwise unchanged.
Validation
vp test run packages/client-runtime/src/connection/supervisor.test.ts -t "explicit disconnect"vp test run packages/client-runtime/src/connection/registry.test.ts -t "remove"vp test run packages/client-runtime/src/platform/storageDocument.test.tsvp checkvp run typecheckvp checkreports the repository's existing 20 unrelated warnings and no errors.Closes #3214
Note
Allow disconnecting backends that are in a connecting or reconnecting state
Updates
SavedBackendListRowin ConnectionsSettings.tsx so the Disconnect button is active during connecting and reconnecting phases. Previously, the button was disabled and showed "Connecting…" during these phases; now it shows "Disconnect" and callsonRemoveinstead ofonConnect.Macroscope summarized 3f22b3c.
Note
Low Risk
Single-component UX change in Connections settings; disconnect still uses the established environment removal path with no auth or connection-layer edits in this diff.
Overview
Saved backend rows in Connections settings no longer lock the action button while the client is in
connectingorreconnecting. The row treats those phases like a live session viacanDisconnect, so the button stays enabled and shows Disconnect (or Disconnecting… while removal runs) instead of a disabled Connecting… state.Connect is unchanged for disconnected, offline, and error phases; disconnect still goes through the existing
onRemove/ environment removal path—no new backend behavior.Reviewed by Cursor Bugbot for commit 3f22b3c. Bugbot is set up for automated code reviews on this repo. Configure here.