[fix/feat:ui] Move menu checks to the right#3233
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Purely visual change that moves checkmark indicators from the left to right side of menu items. No runtime behavior changes - only presentation/styling adjustments to UI components. You can customize Macroscope's approvability policy. Learn more. |
What changed
Selected menu items can hide the default left radio indicator and render their checkmark on the right instead.
Why
Humans are used to selected state being on the right side
UI changes
Before:
After:
Checklist
Testing
vp check apps/web/src/components/ui/menu.tsx apps/web/src/components/chat/TraitsPicker.tsx apps/web/src/components/chat/ChatComposer.tsxNote
Move menu check indicators to the right in chat composer and traits picker
CheckIconthat shows conditionally based on the selected value.hideIndicatorprop toMenuRadioItemin menu.tsx, which suppresses the built-in indicator and adjusts layout so content spans the full width.Macroscope summarized b6f9b6f.
Note
Low Risk
Cosmetic UI changes to menu/select indicators with no logic or data-path changes.
Overview
Selection affordance in composer dropdowns now shows a right-aligned
CheckIconinstead of the default left radio/check indicator.MenuRadioItemgains an optionalhideIndicatorprop that drops the built-in left indicator and uses a single-column layout. Traits picker select and on/off groups use it and render a check only on the active row. The runtime modeSelectuses the same pattern, with the check hidden via opacity on unselected rows so row layout stays aligned.Selection behavior is unchanged; this is presentation only.
Reviewed by Cursor Bugbot for commit b6f9b6f. Bugbot is set up for automated code reviews on this repo. Configure here.