Skip to content

[fix/feat:ui] Move menu checks to the right#3233

Open
sandersonstabo wants to merge 1 commit into
pingdotgg:mainfrom
sandersonstabo:sanderson/fix-ui-right-side-menu-checks
Open

[fix/feat:ui] Move menu checks to the right#3233
sandersonstabo wants to merge 1 commit into
pingdotgg:mainfrom
sandersonstabo:sanderson/fix-ui-right-side-menu-checks

Conversation

@sandersonstabo

@sandersonstabo sandersonstabo commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

What changed

Selected menu items can hide the default left radio indicator and render their checkmark on the right instead.

Why

Humans are used to selected state being on the right side

UI changes

Before:

Before

After:

After

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Testing

vp check apps/web/src/components/ui/menu.tsx apps/web/src/components/chat/TraitsPicker.tsx apps/web/src/components/chat/ChatComposer.tsx

Note

Move menu check indicators to the right in chat composer and traits picker

  • Replaces the default built-in radio/selection indicators in the runtime mode selector (ChatComposer.tsx) and traits picker (TraitsPicker.tsx) with an explicit right-aligned CheckIcon that shows conditionally based on the selected value.
  • Adds a hideIndicator prop to MenuRadioItem in menu.tsx, which suppresses the built-in indicator and adjusts layout so content spans the full width.

Macroscope summarized b6f9b6f.


Note

Low Risk
Cosmetic UI changes to menu/select indicators with no logic or data-path changes.

Overview
Selection affordance in composer dropdowns now shows a right-aligned CheckIcon instead of the default left radio/check indicator.

MenuRadioItem gains an optional hideIndicator prop that drops the built-in left indicator and uses a single-column layout. Traits picker select and on/off groups use it and render a check only on the active row. The runtime mode Select uses the same pattern, with the check hidden via opacity on unselected rows so row layout stays aligned.

Selection behavior is unchanged; this is presentation only.

Reviewed by Cursor Bugbot for commit b6f9b6f. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f7a7b3fa-a86d-4b66-bbbe-cc49d7a2a626

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 20, 2026
@sandersonstabo sandersonstabo marked this pull request as ready for review June 20, 2026 08:16
@macroscopeapp

macroscopeapp Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Purely visual change that moves checkmark indicators from the left to right side of menu items. No runtime behavior changes - only presentation/styling adjustments to UI components.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant