[fix/feat:ui] Preserve open-in editor brand colors#3225
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Pure UI styling change that adds a You can customize Macroscope's approvability policy. Learn more. |
What changed
Editor icons in the open-in picker now keep their intended brand color in both the trigger and dropdown. Generic file manager entries stay muted.
Why
Zed and GitHub-style editor icons were readable in one place and muted in another. The picker now applies one brand-versus-generic icon rule everywhere.
UI changes
Before:
After:
Checklist
Testing
vp check;vp run typecheckpassed locally before splitting these PRs.Note
Preserve brand colors for editor icons in
OpenInPickerAdds a
kindfield ('brand'|'generic') to each option in OpenInPicker.tsx. A newgetOpenInIconClasshelper appliestext-foreground opacity-100to brand editor icons andtext-muted-foregroundto the generic file manager icon, replacing the previously uniform muted styling.Macroscope summarized 831ffbb.
Note
Low Risk
Cosmetic className changes only in
OpenInPicker; no behavior or data paths affected.Overview
Open-in picker icons now use consistent styling: editor entries show full brand colors on both the primary Open button and the dropdown, while Finder/Explorer/Files stays muted.
Each option is tagged
brandvsgeneric, andgetOpenInIconClassappliestext-foreground opacity-100for brands andtext-muted-foregroundfor the file manager—replacing the previous mix where menu icons were always muted and the trigger icon had no explicit color rule.Reviewed by Cursor Bugbot for commit 831ffbb. Bugbot is set up for automated code reviews on this repo. Configure here.