Skip to content

[fix/feat:ui] Preserve open-in editor brand colors#3225

Open
sandersonstabo wants to merge 1 commit into
pingdotgg:mainfrom
sandersonstabo:sanderson/fix-ui-open-in-brand-icon-colors
Open

[fix/feat:ui] Preserve open-in editor brand colors#3225
sandersonstabo wants to merge 1 commit into
pingdotgg:mainfrom
sandersonstabo:sanderson/fix-ui-open-in-brand-icon-colors

Conversation

@sandersonstabo

@sandersonstabo sandersonstabo commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

What changed

Editor icons in the open-in picker now keep their intended brand color in both the trigger and dropdown. Generic file manager entries stay muted.

Why

Zed and GitHub-style editor icons were readable in one place and muted in another. The picker now applies one brand-versus-generic icon rule everywhere.

UI changes

Before:

Before

After:

After

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Testing

vp check; vp run typecheck passed locally before splitting these PRs.

Note

Preserve brand colors for editor icons in OpenInPicker

Adds a kind field ('brand' | 'generic') to each option in OpenInPicker.tsx. A new getOpenInIconClass helper applies text-foreground opacity-100 to brand editor icons and text-muted-foreground to the generic file manager icon, replacing the previously uniform muted styling.

Macroscope summarized 831ffbb.


Note

Low Risk
Cosmetic className changes only in OpenInPicker; no behavior or data paths affected.

Overview
Open-in picker icons now use consistent styling: editor entries show full brand colors on both the primary Open button and the dropdown, while Finder/Explorer/Files stays muted.

Each option is tagged brand vs generic, and getOpenInIconClass applies text-foreground opacity-100 for brands and text-muted-foreground for the file manager—replacing the previous mix where menu icons were always muted and the trigger icon had no explicit color rule.

Reviewed by Cursor Bugbot for commit 831ffbb. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b8ec3f0a-8756-4620-a598-1a0504ffeb76

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 20, 2026
@sandersonstabo sandersonstabo marked this pull request as ready for review June 20, 2026 08:16
@macroscopeapp

macroscopeapp Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Pure UI styling change that adds a kind property to differentiate brand vs generic editor icons and applies appropriate CSS classes. No runtime behavior impact beyond visual appearance of icons in the Open In picker.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant