Version-lock PyPI publish to dispatched daemon version#14
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Verified end-to-end: dispatched this branch with version=1.12.3 and published pilotprotocol 1.12.3 to PyPI (now latest): manylinux + macOS platform wheels (native binaries bundled) plus sdist. Root cause of the prior PyPI failure uncovered + fixed here: twine rejected the dist with InvalidDistribution: malformed field 'license-file' (modern setuptools emits Metadata-Version 2.4; the runner's system twine was too old). The publish job now uses actions/setup-python + twine>=6.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A web4 (daemon) release reached no downstream channel. PyPI is stuck at 1.10.5 because nobody creates a release in this repo, and the publish workflow had no version input and shipped a binary-less wheel (it ran
python -m builddirectly; the oldbuild-binaries.shis a deadcd ../../..leftover from the monorepo era).What
Rewrites
publish.ymlso it:versionworkflow_dispatch input (the canonical trigger — web4's release pipeline dispatches it at the daemon tag, e.g.1.12.3). Keeps the legacyrelease: publishedtrigger.pyproject.tomlversion to the dispatched version → the wheel is version-locked to the daemon, not to stale source.pilot-daemon,pilotctl,pilot-gateway,pilot-updater,libpilot.{so,dylib}) underpilotprotocol/bin/, built from source:libpilot(CGO shared lib) frompilot-protocol/libpilotagainst the same sibling-module checkout set libpilot CI uses; daemon binaries from web4 at the matching tag.twine checks, and skips if the version already exists on PyPI (idempotent).Requires existing secret
PYPI_API_TOKEN(present).Part of the release fan-out (web4 + sdk-node + this).