fix: reuploading file on Save draft resets main doc _status to draft#17011
Open
deepshekhardas wants to merge 1 commit into
Open
fix: reuploading file on Save draft resets main doc _status to draft#17011deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
For an upload-enabled collection with drafts enabled, replacing a published file and saving as a draft incorrectly overwrites the main collection document's _status from 'published' to 'draft'. The bug was in collections/operations/utilities/update.ts where data._status = 'draft' was set unconditionally when isSavingDraft was true, even when updating an existing published document. Fix by only setting _status = 'draft' for new documents (when id is undefined). For existing documents, the main doc should remain published while a draft version is created. Closes payloadcms#16633
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an upload-enabled collection with drafts enabled, replacing a published file and saving as a draft incorrectly overwrites the main collection document's _status from 'published' to 'draft'.
The bug was in \collections/operations/utilities/update.ts\ where \data._status = 'draft'\ was set unconditionally when \isSavingDraft\ was true, even when updating an existing published document.
Fix by only setting _status = 'draft'\ for new documents (when id is undefined). For existing documents, the main doc should remain published while a draft version is created.
Closes #16633