Skip to content

fix(CodeBranchIcon): Replace CodeBranchIcon with RhUiBranchIcon#12489

Open
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-code-branch-icon-with-rh-ui-branch
Open

fix(CodeBranchIcon): Replace CodeBranchIcon with RhUiBranchIcon#12489
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-code-branch-icon-with-rh-ui-branch

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 16, 2026

Copy link
Copy Markdown
Member

We might want a microns version for this - it looks significantly lighter weight-wise.

Part of #12401. Breaking into separate PRs so it is easier to review.

Made with Cursor

Summary by CodeRabbit

  • Style

    • Replaced the “code branch” icon with the “Rh UI branch” icon across DataList, Menu, Table, Tabs, PrimaryDetail, and CustomMenus examples and demos.
    • Applied consistently in the integration demo app to keep the displayed icons aligned.
  • Documentation

    • Updated example and component documentation to reference the new icon, including Markdown import lists used by the demos.

Visual updates only—no changes to behavior or public APIs.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rebeccaalpert, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 6 minutes and 41 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 99e57712-73a7-4dc5-af7e-758a88635e5d

📥 Commits

Reviewing files that changed from the base of the PR and between c0c0cb8 and e2c5a9c.

📒 Files selected for processing (36)
  • packages/react-core/src/components/DataList/examples/DataList.md
  • packages/react-core/src/components/DataList/examples/DataListExpandable.tsx
  • packages/react-core/src/components/DataList/examples/DataListMixedExpandable.tsx
  • packages/react-core/src/components/Menu/examples/Menu.md
  • packages/react-core/src/components/Menu/examples/MenuWithActions.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDescription.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldown.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownBreadcrumbs.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownInitialState.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownSubmenuFunctions.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithIcons.tsx
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
  • packages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsx
  • packages/react-core/src/demos/CustomMenus/examples/DrilldownMenuDemo.tsx
  • packages/react-core/src/demos/DataList/examples/DataListBasic.tsx
  • packages/react-core/src/demos/DataList/examples/DataListExpandableControlInToolbar.tsx
  • packages/react-core/src/demos/DataList/examples/DataListStaticBottomPagination.tsx
  • packages/react-core/src/demos/DataListDemo.md
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/Tabs.md
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
  • packages/react-core/src/demos/examples/Tabs/TabsAndTable.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDrilldownDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableComposableDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableCompoundExpandableDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableEditableCompoundExpandableDemo.tsx
  • packages/react-table/src/components/Table/examples/Table.md
  • packages/react-table/src/components/Table/examples/TableCompoundExpandable.tsx
  • packages/react-table/src/demos/Table.md
  • packages/react-table/src/demos/examples/TableCompoundExpansion.tsx
  • packages/react-table/src/demos/examples/TableSortableResponsive.tsx
  • packages/react-table/src/deprecated/components/Table/examples/LegacyTableCompoundExpandable.tsx
  • packages/react-table/src/deprecated/components/Table/examples/Table.md

Walkthrough

All occurrences of CodeBranchIcon are replaced with RhUiBranchIcon (from @patternfly/react-icons) across example components, demo components, integration test demos, and their accompanying markdown documentation files in the react-core, react-table, and react-integration packages. No logic, structure, or behavior is changed.

Changes

Icon substitution across all examples and demos

Layer / File(s) Summary
CodeBranchIconRhUiBranchIcon across all examples and demos
packages/react-core/src/components/DataList/examples/*, packages/react-core/src/components/Menu/examples/*, packages/react-core/src/demos/CustomMenus/*, packages/react-core/src/demos/DataList/examples/*, packages/react-core/src/demos/*.md, packages/react-core/src/demos/examples/PrimaryDetail/*, packages/react-core/src/demos/examples/Tabs/TabsAndTable.tsx, packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/*, packages/react-integration/demo-app-ts/src/components/demos/TableDemo/*, packages/react-table/src/components/Table/examples/*, packages/react-table/src/demos/*, packages/react-table/src/deprecated/components/Table/examples/*
Every import of CodeBranchIcon is replaced with RhUiBranchIcon, and every JSX render site is updated to use the new component. Markdown import lists are updated to match. No component logic, state, or structure is changed in any file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

Needs design review

Suggested reviewers

  • thatblindgeye
  • kmcfaul
  • nicolethoen
  • phcox
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: replacing CodeBranchIcon with RhUiBranchIcon across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rebeccaalpert rebeccaalpert marked this pull request as draft June 16, 2026 20:29
@patternfly-build

patternfly-build commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-code-branch-icon-with-rh-ui-branch branch from 8675069 to 1fb5aa3 Compare June 17, 2026 13:58
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 17, 2026 14:22
@nicolethoen

Copy link
Copy Markdown
Contributor

needs rebase

@bekah-stephens bekah-stephens left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the filled version of the branch icon would look better visually?

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-code-branch-icon-with-rh-ui-branch branch from 1fb5aa3 to c0c0cb8 Compare June 17, 2026 18:24
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert

Copy link
Copy Markdown
Member Author

I just pushed a second commit with filled @bekah-stephens - let me know what you think.

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants