Skip to content

fix(EyeSlashIcon): Replace EyeSlashIcon with RhUiViewOffFillIcon#12472

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-eye-slash-icon-with-rh-ui-view-off-fill
Open

fix(EyeSlashIcon): Replace EyeSlashIcon with RhUiViewOffFillIcon#12472
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-eye-slash-icon-with-rh-ui-view-off-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 15, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated the password visibility toggle icon in the login form and password generator components for visual consistency.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rebeccaalpert, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 50 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7583bb3c-5ef9-4c48-81fa-9fa2ad3549a8

📥 Commits

Reviewing files that changed from the base of the PR and between 61b4f05 and 7077aa3.

📒 Files selected for processing (3)
  • packages/react-core/src/components/LoginPage/LoginForm.tsx
  • packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md
  • packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx

Walkthrough

EyeSlashIcon is replaced with RhUiViewOffFillIcon as the icon rendered for the "hide password" toggle state. The change applies to the LoginForm component and the PasswordGenerator demo (both the .tsx example and .md documentation).

Changes

Icon Replacement: Password Visibility Toggle

Layer / File(s) Summary
LoginForm password toggle icon
packages/react-core/src/components/LoginPage/LoginForm.tsx
Replaces EyeSlashIcon import with RhUiViewOffFillIcon and updates the toggle button's icon prop to render RhUiViewOffFillIcon when the password is visible.
PasswordGenerator demo icon
packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx, packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md
Replaces EyeSlashIcon import with RhUiViewOffFillIcon in the demo example and updates the toggle icon expression; updates the markdown documentation import accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Needs design review

Suggested reviewers

  • wise-king-sullyman
  • nicolethoen
  • phcox
  • kmcfaul
  • thatblindgeye
  • kaylachumley
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing EyeSlashIcon with RhUiViewOffFillIcon across the LoginForm component, PasswordGenerator demo, and related files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-eye-slash-icon-with-rh-ui-view-off-fill branch from 61b4f05 to 4b9b7be Compare June 17, 2026 17:41
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-eye-slash-icon-with-rh-ui-view-off-fill branch from 4b9b7be to 7077aa3 Compare June 17, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants