Add a "question" bloc in addition of Danger, Info, Positive, Warn

[jonathan-berthet]

📝 Summary

Simply add a bloc with a question mark as bloc for edition.

🖼️ Screenshots

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[max-nextcloud]

Hi @jonathan-berthet

Thanks a lot for the proposal. I just had a quick look at the code and so far it looks good. We might need to adjust some tests though.

Main decision to make here from my point of view is a design question. Do we need this?

Could you explain what motivated you to propose this? Can you give us a concrete example where it would be useful?

@marcoambrosini What do you think from a design point of view?

[marcoambrosini]

I wouldn't mind adding more callout types. they could also be wrapped in one menu entry and we could have a way to decide later which callout type it is later in the page.
Another approach could be to remove the custom icons and fixed callout types and add an emoji picker so that users can decide for themselves and have infinite types of them, like in Notion.

[jonathan-berthet]

Hi both,
I though about this as I am regularly reading reports, and I'm use to take my notes and question in Nextcloud-note application (which use your /text repo). So I am able to highlight important points with current blocs, but not to highlight my questions. Thisbis the reason of my pull request.

@marcoambrosini , your idea is far better! We shall not close people to choose only about the blocs we define, but letting them choose what they want. The pictures you show is great. We must keep a "recent" and/or "favorite" emoji.

Why not the possibility to add custom picture? For example to highlight the action for a specific company - we add their logo, so we can highlight what they have to do. This last point seems not essential or may be complex, only an idea.

Unfortunately I do not have great experience in coding... I can try to update my code, but if a developer can help it will be very helpful. And if we decide to go with Marco's solution.

Regards.

[max-nextcloud]

I think we can approach this step by step. I'm happy to move forward with this PR first.
@jonathan-berthet There are some failing CI tests. They may be results of flaky tests on our side. But the lint prettier check for sure is a code formatting issue.

Could you run

npm run prettier:fix

And commit and push the result?

Thanks a lot!