Skip to content

optimize getting of line number in pytest discovery #26017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaclavHala wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

optimize getting of line number in pytest discovery #26017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion python_files/vscode_pytest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
)

import pytest
from _pytest.python import PyobjMixin
from _pytest._code.code import Code

if TYPE_CHECKING:
from pluggy import Result
Expand Down Expand Up @@ -842,8 +844,18 @@ def create_test_node(
Keyword arguments:
test_case -- the pytest test case.
"""

try:
# test_case.location returns tuple of path and line number
# Obtaining the path is expensive and we do not need it anyway.
# Before falling back to that high-level API, we try to use
# internal API to get just line number without the path.
lineno0 = Code.from_function(cast(PyobjMixin, test_case).obj).firstlineno
except:
lineno0 = test_case.location[1]

test_case_loc: str = (
str(test_case.location[1] + 1) if (test_case.location[1] is not None) else ""
str(lineno0 + 1) if (lineno0 is not None) else ""
)
absolute_test_id = get_absolute_test_id(test_case.nodeid, get_node_path(test_case))
return {
Expand Down Expand Up @@ -1261,3 +1273,4 @@ def pytest_plugin_registered(plugin: object, manager: pytest.PytestPluginManager
and not manager.hasplugin(plugin_name)
):
manager.register(DeferPlugin(), name=plugin_name)