optimize compact_path() in pytest discovery for the common case#26016
Open
vaclavHala wants to merge 1 commit into
Open
optimize compact_path() in pytest discovery for the common case#26016vaclavHala wants to merge 1 commit into
vaclavHala wants to merge 1 commit into
Conversation
…ommon case before using expensive relative_to
Author
|
Hello @eleanorjboyd should I create a separate issue for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested the latest changes to discovery where absolute paths get compacted to global prefix + relative path in each test node, and this change has made the discovery 2 to 3 times slower for us.
The problem is mainly the
pathlib.Path.relative_tooperation which is relatively expensive:This PR adds optimization which first checks using simple
str.startswithif the test is in some subfolder of the root, in which case creating of the relative path is done as trivial (and cheap) substring:I pass the base paths as both
strandpathlib.Path.relative_toso each operation can use whichever form of the base path is needed without having to convert to the other, i.e.str(pathlibPath), which in my testing also adds noticeable overhead.