Fix MSVC C4864 warning and testlib message_impl link error#858
Merged
Conversation
corealloc.h: `small_refill` and `small_alloc` are member templates invoked
through an `Allocator*` of dependent type. MSVC's conformance mode requires
the `template` disambiguator, otherwise it emits C4864 ("expected 'template'
keyword before dependent template name"). Add the keyword to the three
affected call sites.
snmalloc_testlib.cc: `message_impl` is declared non-inline in defines.h but
defined inline in pal.h. On MSVC its COMDAT was never emitted into the test
library (nothing referenced it), so testlib-only tests that see only the
declaration (redblack, seqset) failed to link with LNK2019. Force-emit the
COMDAT via a non-elidable odr-use, keeping the symbol inline everywhere so it
stays ODR-safe with the copies other tests compile from snmalloc.h.
Signed-off-by: Matthew Johnson <matjoh@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corealloc.h:
small_refillandsmall_allocare member templates invoked through anAllocator*of dependent type. MSVC's conformance mode requires thetemplatedisambiguator, otherwise it emits C4864 ("expected 'template' keyword before dependent template name"). Add the keyword to the three affected call sites.snmalloc_testlib.cc:
message_implis declared non-inline in defines.h but defined inline in pal.h. On MSVC its COMDAT was never emitted into the test library (nothing referenced it), so testlib-only tests that see only the declaration (redblack, seqset) failed to link with LNK2019. Force-emit the COMDAT via a non-elidable odr-use, keeping the symbol inline everywhere so it stays ODR-safe with the copies other tests compile from snmalloc.h.