Skip to content

Fix validate-overrides for react-native GitHub org rename#16280

Merged
anuagragith merged 3 commits into
mainfrom
fix/validate-overrides-github-org
Jun 24, 2026
Merged

Fix validate-overrides for react-native GitHub org rename#16280
anuagragith merged 3 commits into
mainfrom
fix/validate-overrides-github-org

Conversation

@anuagragith

@anuagragith anuagragith commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

The upstream React Native repo moved from facebook/react-native to react/react-native. This broke yarn validate-overrides because the react-native-platform-override tool has hardcoded GitHub URLs that now return 301 redirects. For PRs like #16245 that update the override TEMP files, validate-overrides kicks in and tries to validate these files against their base version in the RN repo. But since the path has changed, the network call now fails repeatedly.

This PR updates the hardcoded GitHub URLs in react-native-platform-override tool to use the new org path.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

For PRs like #16245 that update the override TEMP files, validate-overrides kicks in and tries to validate these files against their base version in the RN repo. But since the path has changed, the network call now fails repeatedly.

What

This PR updates the 2 hardcoded URLs in the tool's source:

  • src/GitReactFileRepository.ts:19 — git clone URL used to fetch upstream files
  • src/refFromVersion.ts:100 — GitHub API URL used to resolve abbreviated commit hashes

Why only source files are checked in -
The compiled output (lib-commonjs/) is in .gitignore and is not checked into the repo. During CI, yarn build compiles all packages including react-native-platform-override, regenerating lib-commonjs/ from the TypeScript source before yarn validate-overrides runs. So only the .ts source changes are needed.

Testing

  1. Local build:
  • Ran yarn build in packages/react-native-platform-override/ → succeeded (4.26s)
  • Confirmed regenerated lib-commonjs/*.js files contain updated URLs
  1. Local validation:

Changelog

No

Microsoft Reviewers: Open in CodeFlow

The upstream React Native repo moved from facebook/react-native to
react/react-native. Update the hardcoded GitHub URLs in
react-native-platform-override to use the new org, fixing
validate-overrides failures caused by 301 redirects that node-fetch
cannot handle cleanly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@anuagragith anuagragith requested a review from a team as a code owner June 23, 2026 21:01
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Performance Test Results

Branch: fix/validate-overrides-github-org
Commit: 11776e70
Time: 2026-06-24T00:42:57.273Z
Tests: 161/161 passed

✅ Passed

161 scenario(s) across 28 suite(s) — no regressions

SectionList

Scenario Mean Median StdDev Renders vs Baseline
SectionList mount 3.10ms 3.00ms ±0.74ms 1 -40.0%
SectionList unmount 0.20ms 0.00ms ±0.42ms 0 +0.0%
SectionList rerender 7.10ms 6.50ms ±1.85ms 2 -38.1%
SectionList with-3-sections-15-items 3.50ms 3.00ms ±0.71ms 1 -45.5%
SectionList with-5-sections-50-items 3.50ms 3.50ms ±1.18ms 1 -41.7%
SectionList with-10-sections-200-items 3.50ms 3.00ms ±1.43ms 1 -45.5%
SectionList with-20-sections-200-items 3.30ms 3.00ms ±1.25ms 1 -40.0%
SectionList with-section-separator 1.40ms 1.00ms ±0.52ms 1 -50.0%
SectionList with-item-separator 1.60ms 2.00ms ±0.52ms 1 +0.0%
SectionList with-header-footer 1.50ms 1.00ms ±1.58ms 1 -50.0%
SectionList with-section-footer 1.00ms 1.00ms ±0.00ms 1 -50.0%
SectionList with-sticky-section-headers 1.00ms 1.00ms ±0.00ms 1 -50.0%
SectionList with-empty-list 0.80ms 0.50ms ±1.23ms 1 -50.0%
SectionList with-50-sections-1000-items 1.10ms 1.00ms ±0.32ms 1 -50.0%

FlatList

Scenario Mean Median StdDev Renders vs Baseline
FlatList mount 3.30ms 3.00ms ±1.34ms 1 -25.0%
FlatList unmount 0.20ms 0.00ms ±0.42ms 0 +0.0%
FlatList rerender 6.40ms 6.00ms ±1.17ms 2 -33.3%
FlatList with-10-items 3.00ms 3.00ms ±0.47ms 1 -25.0%
FlatList with-100-items 3.50ms 3.00ms ±0.71ms 1 -40.0%
FlatList with-500-items 3.50ms 3.00ms ±1.27ms 1 -25.0%
FlatList with-1000-items 3.00ms 3.00ms ±0.00ms 1 -25.0%
FlatList horizontal 3.20ms 3.00ms ±1.23ms 1 -40.0%
FlatList with-separator 1.20ms 1.00ms ±0.42ms 1 -50.0%
FlatList with-header-footer 1.40ms 1.00ms ±1.26ms 1 -50.0%
FlatList with-empty-list 0.30ms 0.00ms ±0.48ms 1 -100.0%
FlatList with-get-item-layout 1.10ms 1.00ms ±0.32ms 1 +0.0%
FlatList inverted 1.00ms 1.00ms ±0.00ms 1 -33.3%
FlatList with-num-columns 1.60ms 2.00ms ±0.52ms 1 -33.3%

TouchableOpacity

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity mount 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TouchableOpacity rerender 0.30ms 0.00ms ±0.48ms 2 -100.0%
TouchableOpacity custom-active-opacity 0.50ms 0.50ms ±0.53ms 1 -50.0%
TouchableOpacity disabled 0.40ms 0.00ms ±0.52ms 1 -100.0%
TouchableOpacity with-all-handlers 0.40ms 0.00ms ±0.52ms 1 -100.0%
TouchableOpacity with-hit-slop 0.90ms 1.00ms ±1.20ms 1 +0.0%
TouchableOpacity with-delay 0.40ms 0.00ms ±0.52ms 1 -100.0%
TouchableOpacity nested 1.10ms 1.00ms ±0.74ms 1 +0.0%
TouchableOpacity multiple-10 4.07ms 4.00ms ±1.03ms 1 -33.3%
TouchableOpacity multiple-50 17.13ms 16.00ms ±2.13ms 1 -44.8%
TouchableOpacity multiple-100 15.13ms 14.00ms ±3.18ms 1 -72.0%

ScrollView

Scenario Mean Median StdDev Renders vs Baseline
ScrollView mount 0.40ms 0.00ms ±0.97ms 1 +0.0%
ScrollView unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ScrollView rerender 0.40ms 0.00ms ±0.52ms 2 -100.0%
ScrollView children-20 2.20ms 2.00ms ±0.41ms 1 -50.0%
ScrollView children-100 11.53ms 11.00ms ±2.03ms 1 -31.3%
ScrollView horizontal 2.30ms 2.00ms ±0.67ms 1 -50.0%
ScrollView sticky-headers 2.00ms 2.00ms ±1.05ms 1 -33.3%
ScrollView scroll-indicators 0.50ms 0.50ms ±0.53ms 1 -50.0%
ScrollView nested 0.90ms 1.00ms ±0.57ms 1 +0.0%
ScrollView content-container-style 0.60ms 1.00ms ±0.52ms 1 +0.0%
ScrollView children-500 16.40ms 16.00ms ±3.64ms 1 -15.8%

TouchableHighlight

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight mount 0.40ms 0.00ms ±0.52ms 1 -100.0%
TouchableHighlight unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TouchableHighlight rerender 0.50ms 0.50ms ±0.53ms 2 -50.0%
TouchableHighlight custom-underlay-color 0.90ms 1.00ms ±1.20ms 1 +Infinity%
TouchableHighlight custom-active-opacity 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight disabled 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight with-all-handlers 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight with-hit-slop 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight nested-touchables 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableHighlight multiple-touchables-10 1.80ms 2.00ms ±0.42ms 1 -33.3%
TouchableHighlight multiple-touchables-50 8.60ms 8.00ms ±1.35ms 1 -36.0%
TouchableHighlight multiple-touchables-100 16.60ms 16.00ms ±2.07ms 1 -28.9%

Pressable

Scenario Mean Median StdDev Renders vs Baseline
Pressable mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Pressable unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Pressable rerender 0.50ms 0.50ms ±0.53ms 2 +0.0%
Pressable with-all-handlers 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable with-style-function 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable disabled 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable with-hit-slop 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable nested 0.30ms 0.00ms ±0.48ms 1 -100.0%
Pressable multiple-10 1.93ms 2.00ms ±0.46ms 1 -33.3%
Pressable multiple-50 10.33ms 10.00ms ±1.29ms 1 -28.6%
Pressable multiple-100 11.13ms 9.00ms ±6.30ms 1 -25.0%

Modal

Scenario Mean Median StdDev Renders vs Baseline
Modal mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Modal rerender 0.40ms 0.00ms ±0.52ms 2 +0.0%
Modal slide-animation 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal fade-animation 0.10ms 0.00ms ±0.32ms 1 +0.0%
Modal transparent 0.20ms 0.00ms ±0.42ms 1 +0.0%
Modal with-callbacks 0.10ms 0.00ms ±0.32ms 1 +0.0%
Modal rich-content 1.00ms 1.00ms ±0.00ms 1 -50.0%
Modal with-accessibility 0.30ms 0.00ms ±0.48ms 1 +0.0%

Image

Scenario Mean Median StdDev Renders vs Baseline
Image mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Image rerender 0.00ms 0.00ms ±0.00ms 2 +0.0%
Image with-resize-mode 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-border-radius 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-tint-color 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-blur-radius 0.00ms 0.00ms ±0.00ms 1 +0.0%
Image with-accessibility 0.00ms 0.00ms ±0.00ms 1 +0.0%
Image multiple-10 0.80ms 1.00ms ±1.01ms 1 +0.0%
Image multiple-50 3.27ms 2.00ms ±3.28ms 1 -33.3%
Image multiple-100 5.40ms 5.00ms ±1.35ms 1 -37.5%

ActivityIndicator

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ActivityIndicator rerender 0.10ms 0.00ms ±0.32ms 2 +0.0%
ActivityIndicator size-large 0.00ms 0.00ms ±0.00ms 1 +0.0%
ActivityIndicator size-small 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator with-color 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator not-animating 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator with-accessibility 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator multiple-10 0.87ms 1.00ms ±0.74ms 1 +0.0%
ActivityIndicator multiple-50 2.33ms 2.00ms ±0.49ms 1 -50.0%
ActivityIndicator multiple-100 5.80ms 5.00ms ±1.78ms 1 -28.6%

Switch

Scenario Mean Median StdDev Renders vs Baseline
Switch mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Switch rerender 0.10ms 0.00ms ±0.32ms 2 -100.0%
Switch value-true 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch disabled 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch custom-colors 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch on-value-change 0.10ms 0.00ms ±0.32ms 1 +0.0%
Switch with-accessibility 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch multiple-10 1.00ms 1.00ms ±0.00ms 1 -50.0%
Switch multiple-50 6.73ms 5.00ms ±2.25ms 1 -44.4%
Switch multiple-100 12.60ms 11.00ms ±3.11ms 1 -31.3%

Button

Scenario Mean Median StdDev Renders vs Baseline
Button mount 0.50ms 0.50ms ±0.53ms 1 -50.0%
Button unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Button rerender 0.70ms 1.00ms ±0.48ms 2 +0.0%
Button disabled 0.30ms 0.00ms ±0.48ms 1 -100.0%
Button with-color 0.50ms 0.50ms ±0.53ms 1 +0.0%
Button with-accessibility 0.40ms 0.00ms ±0.52ms 1 -100.0%
Button multiple-10 3.73ms 4.00ms ±1.16ms 1 -33.3%
Button multiple-50 13.40ms 15.00ms ±5.50ms 1 -44.4%
Button multiple-100 11.27ms 10.00ms ±2.31ms 1 -47.4%

TextInput

Scenario Mean Median StdDev Renders vs Baseline
TextInput mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TextInput rerender 0.30ms 0.00ms ±0.48ms 2 +0.0%
TextInput multiline 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput with-value 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput styled 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput multiple-100 5.13ms 5.00ms ±0.74ms 1 -28.6%

View

Scenario Mean Median StdDev Renders vs Baseline
View mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
View unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
View rerender 0.10ms 0.00ms ±0.32ms 2 +0.0%
View nested-50 2.40ms 2.00ms ±0.91ms 1 -33.3%
View nested-100 5.27ms 5.00ms ±1.10ms 1 -28.6%
View shadow 0.00ms 0.00ms ±0.00ms 1 +0.0%
View border-radius 0.00ms 0.00ms ±0.00ms 1 +0.0%
View nested-500 12.27ms 8.00ms ±8.56ms 1 -20.0%

Text

Scenario Mean Median StdDev Renders vs Baseline
Text mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Text unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Text rerender 0.10ms 0.00ms ±0.32ms 2 +0.0%
Text long-1000 0.10ms 0.00ms ±0.32ms 1 +0.0%
Text nested 0.20ms 0.00ms ±0.42ms 1 +0.0%
Text styled 0.00ms 0.00ms ±0.00ms 1 +0.0%
Text multiple-100 6.13ms 6.00ms ±1.36ms 1 -14.3%

SectionList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
SectionList native mount 2.99ms 2.90ms ±0.31ms 1 -55.5%

FlatList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
FlatList native mount 2.96ms 2.77ms ±0.34ms 1 -70.0%

TouchableHighlight.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight native mount 0.94ms 0.94ms ±0.06ms 1 -55.0%

TouchableOpacity.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity native mount 1.12ms 1.09ms ±0.13ms 1 -65.2%

Pressable.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Pressable native mount 1.00ms 0.99ms ±0.06ms 1 -60.7%

ScrollView.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ScrollView native mount 2.27ms 2.08ms ±0.38ms 1 -48.7%

ActivityIndicator.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator native mount 0.91ms 0.87ms ±0.16ms 1 -65.1%

TextInput.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TextInput native mount 1.53ms 1.36ms ±0.32ms 1 -66.8%

Switch.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Switch native mount 1.13ms 0.87ms ±0.62ms 1 -49.8%

Button.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Button native mount 1.48ms 1.44ms ±0.19ms 1 -44.7%

Modal.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Modal native mount 0.76ms 0.71ms ±0.21ms 1 -41.8%

Image.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Image native mount 1.16ms 1.12ms ±0.10ms 1 -50.5%

View.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
View native mount 0.71ms 0.71ms ±0.07ms 1 -50.3%

Text.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Text native mount 1.04ms 0.86ms ±0.46ms 1 -50.6%

The root package.json pinned react-native-platform-override to a
published npm version (0.0.0-canary.1017), which meant yarn
validate-overrides ran the old npm code rather than the local workspace
source. Since the npm version still has the old facebook/react-native
GitHub URL, CI agents that cannot follow the 301 redirect fail.

Change the dependency to workspace:* so Yarn resolves to the local
workspace package (which contains our URL fix), matching the pattern
used by other workspace tools (@rnw-scripts/*).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@anuagragith anuagragith merged commit c3bae8f into main Jun 24, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants