refactor: USize/ISize handling in bv_decide#14227
Open
hargoniX wants to merge 4 commits into
Open
Conversation
|
Mathlib CI status (docs):
|
97077c7 to
e3aee1e
Compare
TwoFX
reviewed
Jun 30, 2026
e3aee1e to
e9edb7b
Compare
Collaborator
|
Reference manual CI status:
|
Contributor
Author
|
!bench |
|
Benchmark results for e9edb7b against 28b99ec are in. No significant results found. @hargoniX
Small changes (2✅, 13🟥)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the way that
bv_decidehandlesUSizeandISize. This is necessary forSymMsupport inbv_decidebecause callingrevertinSymMis illegal.Instead of building a custom motive to replace
USize/ISizeconstants withBitVecones, it now uses a modifiedint_toBitVecsimp set. For all fixed widthIntXthis still contains the original lemmas. ForUSize/ISizeit contains lemmas that convert toBitVec 32orBitVec 64, conditionally on which of the two assumptions is available. Through thisUSize/ISizealready get converted to fixed-widthBitVecin theint_toBitVecsimppass inbv_decide.