chore: delete unused C++ code#14203
Open
eric-wieser wants to merge 3 commits into
Open
Conversation
eric-wieser
changed the title
output_channel.houtput_channel.h
eric-wieser
commented
Jun 28, 2026
| class file_output_channel : public output_channel { | ||
| std::ofstream m_out; | ||
| public: | ||
| file_output_channel(char const * fname):m_out(fname) {} |
Contributor
Author
There was a problem hiding this comment.
This didn't actually check that m_out was good(). Rather that fixing it, better to delete the unused code!
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
eric-wieser
changed the title
output_channel.h
eric-wieser
force-pushed
the
patch-78
branch
2 times, most recently
from
8a7b144 to
dd4fd0a
Compare
eric-wieser
commented
Jun 28, 2026
| If the environment has an impredicative Prop, it also assumes heq is defined. | ||
| If the environment does not have an impredicative Prop, then it also assumes lift is defined. | ||
| */ | ||
| declaration mk_no_confusion_type(elab_environment const & env, name const & n); |
Contributor
Author
There was a problem hiding this comment.
The declarations in this file are not provided by any cpp file
eric-wieser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these headers are never included, while others are used to define functions which are ultimately never called as their implementation has moved from C++ to Lean.