perf: avoid spawning a new thread per worker output message#14185
Open
Kha wants to merge 1 commit into
Open
Conversation
Member
Author
|
!bench |
|
Benchmark results for 776f9fb against 08c8b6a are in. No significant results found. @Kha
Medium changes (1🟥)
Small changes (5✅, 2🟥)
|
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Member
Author
|
Instructions increases might be from additional parallelism? Certainly look harmless when all -clocks are pointing in the right direction |
Kha
commented
Jun 26, 2026
| let params : PublishDiagnosticsParams ← fromJson? (toJson params) |>.toOption | ||
| params.version? | ||
| | some (.notification "$/lean/fileProgress" (some params)) => | ||
| let params : LeanFileProgressParams ← fromJson? (toJson params) |>.toOption |
Member
Author
There was a problem hiding this comment.
Tangentially, it would probably make sense to avoid the JSON roundtrip in at least this case at it happens so often
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also reduces number of samply tracks for re-elab tests from ~3000 to ~40