feat: switch LMD-GHOST + 3SF-mini for Goldfish + RLMD-GHOST + BFT#434
Draft
MegaRedHand wants to merge 7 commits into
Draft
feat: switch LMD-GHOST + 3SF-mini for Goldfish + RLMD-GHOST + BFT#434MegaRedHand wants to merge 7 commits into
MegaRedHand wants to merge 7 commits into
Conversation
main (#447/#449/#450) merged cleanly textually, but the simple BFT finality condition removed slot_is_justifiable_after, which main's block_builder and store still called. Reconciled those call sites to the new model (every slot justifiable; finalize only on consecutive source+1 == target): - store::get_attestation_target_with_checkpoints: drop the justifiability walk-back (now a no-op); finalized arg unused, kept as _finalized. - block_builder: drop the target_not_justifiable rejection; the finalizes predicate now checks source.slot + 1 == target.slot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description / Motivation
What Changed
Correctness / Behavior Guarantees
Tests Added / Run
Related Issues / PRs
✅ Verification Checklist
make fmt— cleanmake lint(clippy with-D warnings) — cleancargo test --workspace --release— all passing