Skip to content
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions nodejs/test/e2e/rpc_session_state.e2e.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,19 @@
const before = await session.rpc.model.getCurrent();
expect(before.modelId).toBeTruthy();

const result = await session.rpc.model.switchTo({
const switchPromise = session.rpc.model.switchTo({
modelId: "gpt-4.1",
reasoningEffort: "high",
});

const eventPromise = waitForEvent(session, (event) => event.type === "session.model_change", "session.model_change event after switchTo");
Comment thread
Morabbin marked this conversation as resolved.
Outdated

Comment thread
Morabbin marked this conversation as resolved.
Outdated
const [result, event] = await Promise.all([switchPromise, eventPromise]);
Comment thread
Morabbin marked this conversation as resolved.
Outdated
const after = await session.rpc.model.getCurrent();

expect(result.modelId).toBe("gpt-4.1");
expect(after.modelId).toBe(before.modelId);
expect(result.modelId).toBeTruthy();
Comment thread
Morabbin marked this conversation as resolved.
expect(after.modelId).toBe(result.modelId);

Check failure on line 72 in nodejs/test/e2e/rpc_session_state.e2e.test.ts

View workflow job for this annotation

GitHub Actions / Node.js SDK Tests (macos-latest)

test/e2e/rpc_session_state.e2e.test.ts > Session-scoped RPC > should call session rpc model switchto

AssertionError: expected 'claude-sonnet-4.5' to be 'gpt-4.1' // Object.is equality Expected: "gpt-4.1" Received: "claude-sonnet-4.5" ❯ test/e2e/rpc_session_state.e2e.test.ts:72:31

Check failure on line 72 in nodejs/test/e2e/rpc_session_state.e2e.test.ts

View workflow job for this annotation

GitHub Actions / Node.js SDK Tests (windows-latest)

test/e2e/rpc_session_state.e2e.test.ts > Session-scoped RPC > should call session rpc model switchto

AssertionError: expected 'claude-sonnet-4.5' to be 'gpt-4.1' // Object.is equality Expected: "gpt-4.1" Received: "claude-sonnet-4.5" ❯ test/e2e/rpc_session_state.e2e.test.ts:72:31
expect((event as any).data.newModel).toBe(result.modelId);

Check warning on line 73 in nodejs/test/e2e/rpc_session_state.e2e.test.ts

View workflow job for this annotation

GitHub Actions / Node.js SDK Tests (macos-latest)

Unexpected any. Specify a different type

Check warning on line 73 in nodejs/test/e2e/rpc_session_state.e2e.test.ts

View workflow job for this annotation

GitHub Actions / Node.js SDK Tests (windows-latest)

Unexpected any. Specify a different type
Comment thread
Morabbin marked this conversation as resolved.
Outdated

await session.disconnect();
});
Expand Down
Loading