Update workflow to support multiple OS environments#702
Open
fadrian06 wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions test workflow to expand CI coverage across multiple operating systems, ensuring the FlightPHP core test suite is exercised on Ubuntu, Windows, and macOS for each configured PHP version.
Changes:
- Add an
osentry to the workflow matrix (Ubuntu/Windows/macOS). - Switch
runs-onto use the matrix-selected OS value.
… writable' contains 'Invalid target path: contains directory traversal'.
fadrian06
force-pushed
the
ci-add-multiple-OSs
branch
from
0bb32f2 to
237d567
Compare
…newlines On Windows, PHP_EOL is \\r\\n but the CLI library writes \\n to the output file. The removeColors() helper converts \\r\\n→\\n, so using str_replace(PHP_EOL, '') afterwards failed to strip those \\n on Windows, leaving newlines in the haystack while the needle had none. Fix: replace both \\r\\n and \\n so all newline variants are stripped from both needle and haystack before comparison, making the test platform-independent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the test workflow configuration to expand the operating systems used in the test matrix. Now, tests will run on Ubuntu, Windows, and macOS environments for each PHP version.
Test matrix improvements:
osmatrix to the workflow, so tests are now run onubuntu-latest,windows-latest, andmacos-latestfor each PHP version. Updated theruns-onfield to use the matrix value. (.github/workflows/test.yml)