Skip to content

Re-add writable directory check for target path #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fadrian06 wants to merge 1 commit into from
Closed

Re-add writable directory check for target path #701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions flight/net/UploadedFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,15 @@ public function moveTo(string $targetPath): void
throw new Exception($this->getUploadErrorMessage($this->error));
}

if (is_writeable(dirname($targetPath)) === false) {
throw new Exception('Target directory is not writable');
}

// Prevent path traversal attacks
if (strpos($targetPath, '..') !== false) {
throw new Exception('Invalid target path: contains directory traversal');
}

if (is_writeable(dirname($targetPath)) === false) {
throw new Exception('Target directory is not writable');
}
Comment on lines +139 to +141

// Prevent absolute paths (basic check for Unix/Windows)
if ($targetPath[0] === '/' || (strlen($targetPath) > 1 && $targetPath[1] === ':')) {
throw new Exception('Invalid target path: absolute paths not allowed');
Expand Down
Loading