Skip to content

Fix event cursor pagination links#2322

Merged
niemyjski merged 1 commit into
mainfrom
issue/fix-event-cursor-pagination-links
Jun 23, 2026
Merged

Fix event cursor pagination links#2322
niemyjski merged 1 commit into
mainfrom
issue/fix-event-cursor-pagination-links

Conversation

@niemyjski

Copy link
Copy Markdown
Member

Summary

  • Stop cursor-paged responses from emitting rel="next" when the repository says there are no more results.
  • Add regression coverage for partial final cursor pages and link helper generation.

Root Cause

  • EventController passed the last row sort token into OkWithResourceLinks for every non-empty cursor page.
  • OkWithResourceLinks generated a next link solely from a non-empty after token, ignoring HasMore, so a partial final page advertised a phantom cursor.

Validation

  • dotnet test -- --filter-class Exceptionless.Tests.Miscellaneous.EfficientPagingTests
  • dotnet test -- --filter-class Exceptionless.Tests.Controllers.EventControllerTests
  • Local Aspire UI: /next/event/all?limit=10 showed Page 1 of 2, then Page 2 of 2 with 4 rows and Next disabled.

Breaking Changes

None.

@niemyjski niemyjski requested a review from ejsmith June 23, 2026 00:43
@niemyjski niemyjski self-assigned this Jun 23, 2026
@niemyjski niemyjski added the dependencies Pull requests that update a dependency file label Jun 23, 2026
Comment thread tests/Exceptionless.Tests/Controllers/EventControllerTests.cs Outdated
@niemyjski niemyjski force-pushed the issue/fix-event-cursor-pagination-links branch from 3f912a5 to 7b18a35 Compare June 23, 2026 00:46
@niemyjski niemyjski marked this pull request as ready for review June 23, 2026 00:48
@niemyjski niemyjski force-pushed the issue/fix-event-cursor-pagination-links branch from 7b18a35 to cf7f5cf Compare June 23, 2026 00:54
@niemyjski niemyjski merged commit 5a645c9 into main Jun 23, 2026
9 checks passed
@niemyjski niemyjski deleted the issue/fix-event-cursor-pagination-links branch June 23, 2026 00:56
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.AppHost 39% 40% 134
Exceptionless.Core 70% 63% 8002
Exceptionless.Insulation 24% 23% 203
Exceptionless.Web 72% 62% 4165
Summary 69% (14262 / 20628) 62% (7409 / 12046) 12504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants