Fix event cursor pagination links#2322
Merged
Merged
Conversation
3f912a5 to
7b18a35
Compare
ejsmith
approved these changes
Jun 23, 2026
7b18a35 to
cf7f5cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rel="next"when the repository says there are no more results.Root Cause
EventControllerpassed the last row sort token intoOkWithResourceLinksfor every non-empty cursor page.OkWithResourceLinksgenerated a next link solely from a non-emptyaftertoken, ignoringHasMore, so a partial final page advertised a phantom cursor.Validation
dotnet test -- --filter-class Exceptionless.Tests.Miscellaneous.EfficientPagingTestsdotnet test -- --filter-class Exceptionless.Tests.Controllers.EventControllerTests/next/event/all?limit=10showedPage 1 of 2, thenPage 2 of 2with 4 rows and Next disabled.Breaking Changes
None.