fix http gaetway route segments strict matching#2479
Open
alstanchev wants to merge 2 commits into
Open
Conversation
alstanchev
changed the title
Signed-off-by: Aleksandar Stanchev <aleksandar.stanchev@bosch.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Cover the strict full-segment matching contract: exact match, trailing slash, typo-suffix rejection, sibling backtracking, exact unmatched remainder delegation, case-sensitivity, root/empty path, shorter-request rejection and decode-then-compare behavior. Signed-off-by: Aleksandar Stanchev <aleksandar.stanchev@bosch.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alstanchev
force-pushed
the
bugfix/route-segments
branch
from
fba22ee to
1ff6db1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a strange behavior where if for example
/devops/logging/gaDeway
is called it is correctly timing out as there is no such service but if we add a letter to the 'logging' segment
/devops/loggingA/gaDeway
the logging part is matched as a prefix then the rest 'A/gaDeway' is passed along but since the next handle checks for leading slash the segment is dropped and the call is handled as it was
/devops/logging
This behavior can potentially reached at any place where no strict segment matching is done.
System tests run:
https://github.com/eclipse-ditto/ditto/actions/runs/28428560314