Skip to content

[tests] Mark tests inconclusive on premature response termination. Fixes #25873#25875

Draft
rolfbjarne wants to merge 1 commit into
mainfrom
dev/rolf/fix-flaky-messagehandlertest-premature-response
Draft

[tests] Mark tests inconclusive on premature response termination. Fixes #25873#25875
rolfbjarne wants to merge 1 commit into
mainfrom
dev/rolf/fix-flaky-messagehandlertest-premature-response

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

The MessageHandlerTest.AcceptSslCertificatesServicePointManager test intermittently fails in CI because httpbin.org drops the TCP connection mid-response, producing an HttpIOException: The response ended prematurely. The existing IgnoreInCIIfBadNetwork helper didn't handle this exception type, so the test was reported as a hard failure rather than being marked inconclusive.

This adds an IgnoreInCIIfResponseEndedPrematurely check that catches HttpIOException and marks the test Inconclusive when running in CI, matching the pattern used for other transient network errors (DNS failures, timeouts, connection lost).

Fixes #25873


🤖 Pull request created by Copilot

… the response

Add IgnoreInCIIfResponseEndedPrematurely to handle HttpIOException
("response ended prematurely") in IgnoreInCIIfBadNetwork. This marks
such tests as Inconclusive in CI instead of failing, since premature
response termination from external services like httpbin.org is a
network issue, not a test failure.

Fixes #25873

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #e40e95e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: e40e95e24bd2f09f034329d5ad882f2ed78a8f52 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #e40e95e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: e40e95e24bd2f09f034329d5ad882f2ed78a8f52 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #e40e95e] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: e40e95e24bd2f09f034329d5ad882f2ed78a8f52 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e40e95e24bd2f09f034329d5ad882f2ed78a8f52 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 [CI Build #e40e95e] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 0 tests failed, 194 tests passed.

Failures

❌ generator tests

🔥 Failed catastrophically on VSTS: test results - generator (no summary found).

Html Report (VSDrops) Download

Successes

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: e40e95e24bd2f09f034329d5ad882f2ed78a8f52 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Flaky: MessageHandlerTest.AcceptSslCertificatesServicePointManager — httpbin.org premature response termination

2 participants