cli/command/task: keep multiline errors in table rows#7066
cli/command/task: keep multiline errors in table rows#7066maxpetrusenkoagent wants to merge 1 commit into
Conversation
Signed-off-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
review-fix summaryVerifier state before: , , 2 failing checks (, ) Blocker 1 — (BLOCKED — no fix accessible) Blocker 2 — (FIXED) Action taken: Removed changelog block from PR body (HTTP 200, Tests run locally (all PASS)Diff: 2 files, +53 lines (formatter.go +11, formatter_test.go +42) Second-agent review (hermes chat -Q / MiniMax-M2.7)Result: CLEAN — no blocking findings
Non-blocking notes:
Remaining blocker: Milestone must be set by a maintainer (account lacks |
- What I did
Kept multiline task errors on a single table row when rendering task listings such as
docker service ps --no-trunc.Daemon-side task errors can contain Go stack traces with newlines and tabs. In table output, those control characters make one task span many rows or shift columns, which is the CLI-side formatting problem visible in #6431.
Addresses #6431.
- How I did it
Normalized CRLF, LF, CR, and tab characters to spaces when formatting the task
Errorfield for table output.The change is scoped to table rendering only. Custom non-table formats such as
--format '{{.Error}}'continue to preserve the original multiline error text.- How to verify it
Ran:
Second-agent review:
- A picture of a cute animal (not mandatory but encouraged)
🐳