V6.3.6 dev feat/standardise df#665
Open
timcadman wants to merge 26 commits into
Open
Conversation
….6-dev-feat/standardise-df
This was referenced May 14, 2026
Closed
Merged
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
Requires update to obiba_opal-upload_testing_datasets.R.
Done in PR for dsBaseClient-v6.3.6-dev
Update 'v6.3.6-dev-feat/standardize-df' with 'v6.3.6-dev'
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
The "ds.test_env$ping_options <- "list(timeout=60)" it appears now needs to be "ds.test_env$ping_options <- config(timeout=60)", being tested in another branch.
…atashield/dsBaseClient into v6.3.6-dev-feat/standardise-df
StuartWheater
approved these changes
Jul 1, 2026
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
Changes appear correct.
- Passes ci tests apart from 'test-smk-ds.standardDf' and 'test-perf-ds.standardDf'
- devtools::check did not indicate any issue
- devtools::check_win_release did not indicate any issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.