feat: structured load statistics from insert_into_target_tables#71
Merged
Conversation
…dataclass insert_into_target_tables now returns LoadStats(inserted, existing, duration_temp_insert, duration_merge, duration_cleanup). merge_into_target_tables returns MergeStats(inserted, existing, duration). insert_into_temp_tables returns the phase duration as a float. Row counts use the first INSERT rowcount per table (the data-table INSERT; join-table INSERTs are ignored). Backends that do not report rowcount for INSERT…FROM SELECT (e.g. DuckDB) silently yield 0 for inserted/existing. Both types are exported from the package root. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…2 fork deprecation warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insert_into_target_tablespreviously returned a bareint(total inserted rows).It now returns a
LoadStatsdataclass with inserted/existing row counts andper-phase timing, giving callers visibility into both deduplication effectiveness
and load performance without any extra instrumentation.
Changes
Document.insert_into_target_tables→LoadStats