Add offset slice views and split_first_mut#153
Draft
coord-e wants to merge 4 commits into
Draft
Conversation
This was referenced Jun 28, 2026
74906dd to
4e5abf2
Compare
0227165 to
6dcd001
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seqwith an offset fieldsubsequencesupport withoutprependSeqrepresentationsplit_first_mutextern spec usingMut::newandsubsequenceDesign
The offset lets multiple slice views share one underlying array while changing their logical start and length.
subsequence(start, end)preserves the array, advances the offset bystart, and sets the view length toend - start.Known limitation
The current handling of mutable references returned inside tuples can make mutation propagation through
split_first_mutunsound. This is accepted for this PR and documented in the related discussion on #124: #124 (comment)Validation
cargo checksplit_first_mutpass/fail pairs with the default Spacer solver