build-locally.sh: Fixed build issue and added instructions for viewing the result#3698
Merged
Conversation
olehermanse
commented
Jun 19, 2026
olehermanse
commented
Member
- generator/build/Dockerfile: Ensured we don't have an outdated (cached) apt-get update for install.sh script
- build-locally.sh: Added instructions for viewing the resulting build in a browser
Member
Author
|
@cf-bottom jenkins, please |
olehermanse
requested review from
aleksandrychev,
craigcomstock,
larsewi and
nickanderson
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/88/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-88/output/_site/ |
…) apt-get update for install.sh script Without this change, you can end up in a situaton where the lines above from the Dockerfile are cached and outdated. The apt-get update is especially relevant since the install.sh script tries to do apt-get install things, which has a tendency to fail if apt-get update is not recent. Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
…in a browser Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Member
Author
|
@cf-bottom jenkins, please. |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/89/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-89/output/_site/ |
larsewi
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.