ENT-14104: Added GETPATCH protocol command for serving leech2 patches#6163
Open
larsewi wants to merge 2 commits into
Open
ENT-14104: Added GETPATCH protocol command for serving leech2 patches#6163larsewi wants to merge 2 commits into
larsewi wants to merge 2 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
larsewi
force-pushed
the
leech2-patch-stream
branch
2 times, most recently
from
6ae1b0d to
7023be6
Compare
Contributor
Author
|
@cf-bottom Jenkins please :) |
larsewi
requested review from
SimonThalvorsen,
craigcomstock,
olehermanse and
victormlg
larsewi
force-pushed
the
leech2-patch-stream
branch
from
7023be6 to
55294e4
Compare
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13939/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13939/ |
larsewi
force-pushed
the
leech2-patch-stream
branch
from
55294e4 to
4054ba7
Compare
olehermanse
approved these changes
Jun 12, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
Looks good overall. Some comments / suggestions below.
larsewi
force-pushed
the
leech2-patch-stream
branch
from
4054ba7 to
c60caf3
Compare
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
leech2-patch-stream
branch
from
c60caf3 to
d6ab0ee
Compare
The hub sends 'GETPATCH <hash>' over the established TLS connection, and the server replies with a leech2 patch using a new patch stream API, which reuses the wire format from the file stream protocol. The patch is created by an enterprise hook; CFEngine Community refuses the request. This introduces protocol version 5 - "leech2". Ticket: ENT-14104 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
leech2-patch-stream
branch
from
d6ab0ee to
0e8e37b
Compare
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13970/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13970/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hub sends 'GETPATCH ' over the established TLS connection, and the server replies with a leech2 patch using a new patch stream API, which reuses the wire format from the file stream protocol. The patch is created by an enterprise hook; CFEngine Community refuses the request. This introduces protocol version 5 - "leech2".
Ticket: ENT-14104
Together with: