SP-992: Add Git capabilities to config package export/import#379
Open
Zgjim Haziri (ZgjimHaziri) wants to merge 5 commits into
Open
SP-992: Add Git capabilities to config package export/import#379Zgjim Haziri (ZgjimHaziri) wants to merge 5 commits into
Zgjim Haziri (ZgjimHaziri) wants to merge 5 commits into
Conversation
Add `config package export`, the counterpart of `config package import`, backed by the new single-package export API (pacman#1997). Exports a package's staging (draft) version in the package format: unzipped into a <packageKey> directory by default, or as a <packageKey>.zip file with --zip. Output is written to the current working directory. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Add --gitProfile/--gitBranch options to 'config package export' and 'config package import', reusing the existing GitService that already backs the 't2tc package' and legacy 'config' commands. - export: when --gitBranch is set, the package is pushed unzipped to the branch (--zip is ignored for the Git path). - import: when --gitBranch is set, the branch is pulled and the package is imported; --gitBranch is mutually exclusive with --file/--directory. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve modify/delete conflict in the configuration-management tests. SP-1089 (#374) deleted the per-module unit spec (tests/commands/configuration-management/module.spec.ts) in favor of an integration spec. Port the `config package export` handler tests into tests/integration/commands/configuration-management.spec.ts (driven via the CLI parser, so the unzipped default asserts zip=false) and accept the deletion of the old unit spec. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
…ies-package-commands Bring the updated base (now including main's SP-1089 integration-test refactor) into the Git-capabilities branch. Resolve the modify/delete conflict on the deleted unit spec by porting the import/export Git tests into tests/integration/commands/configuration-management.spec.ts and updating the existing single-package import/export assertions for the new gitBranch argument. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve conflicts after the base PR #378 (SP-873 single package export) was squash-merged into main. This branch is stacked on SP-873, so it already contained those changes plus the SP-992 Git capabilities on top. Every conflict was therefore resolved by keeping this branch's superset version (single-package-export.service.ts, module.ts, file-service.ts, the export/file-service unit specs, and config-commands.md). Also dropped a duplicate "config package export" describe block that the auto-merge re-added from main in the integration spec (it asserted the old 2-arg exportPackage signature). The resulting tree is identical to this branch's pre-merge HEAD; tsc and the full jest suite pass. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
--gitProfile/--gitBranchGit support to the single-package commandsconfig package exportandconfig package import, mirroring the existing behavior on thet2tc packageand legacyconfigcommands and reusing the existingGitService(pushToBranch/pullFromBranch).config package export --gitBranch <branch>: pushes the package in its unzipped package layout to the branch instead of writing to the working directory (--zipis ignored on the Git path).config package import --gitBranch <branch>: pulls the branch and imports the package; mutually exclusive with--file/--directory.--gitProfilewithout--gitBranchis rejected, consistent with the other commands.Stacked on top of #378 (single package export). The base will retarget to
mainonce #378 merges.Relevant links
Checklist
Made with Cursor