Refine iteration variable validation in CEL macros.#1096
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_933941435
branch
from
2185f73 to
e23f1d2
Compare
This change introduces stricter validation for iteration variables in standard CEL macros like `all`, `exists`, `map`, and `filter`. Iteration variables must now be simple identifiers, disallowing names that start with a dot (e.g., `.x`) and preventing the use of the internal accumulator variable `__result__`. The validation logic is now shared between the standard macros and the comprehensions extension. PiperOrigin-RevId: 933966053
copybara-service
Bot
force-pushed
the
test_933941435
branch
from
e23f1d2 to
bb0b958
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refine iteration variable validation in CEL macros.
This change introduces stricter validation for iteration variables in standard CEL macros like
all,exists,map, andfilter. Iteration variables must now be simple identifiers, disallowing names that start with a dot (e.g.,.x) and preventing the use of the internal accumulator variable__result__. The validation logic is now shared between the standard macros and the comprehensions extension.